fix 7z on Mac when frozen by removing old binaries #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axu2
changed the title
axu2
changed the title
axu2
changed the title
axu2
changed the title
This was referenced Jul 30, 2023
axu2
changed the title
axu2
changed the title
axu2
changed the title
|
Superseded by #566 due to merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7z on Apple Silicon is stored in a different location.
Also removed the binaries so users must install their own 7z from homebrew.
The old versions don't work on either Intel or Apple Silicon on latest macOS. If we leave them there KCC will detect them and not ask the user to install a more updated version of 7z. So any CBZ conversions will fail without a good error.
fixes #528
Fixes #436 together with #564
@Beebeedeedop @chenobies @sparkirat @maxthiel